Skip to content

Obsoletion warning for DataAttribute #2829

Description

@jnm2

Quoting Charlie,

DataAttribute is a class that was somewhat important in earlier versions of NUnit. Currently, it's a holdover and is not used in the code at all. We left it in the code to avoid needlessly breaking anything.

This seems like a good thing to document in the source. Can we document this using an obsoletion warning so that people who use it become aware?

[Obsolete("Holdover from NUnit v2. Please inherit from Attribute or PropertyAttribute and " +
          "implement IParameterDataSource.", error: false)]

Activity

  1. CharliePoole commented on Apr 27, 2018

    @CharliePoole
    Member

    We'd have to change the inheritance of the four attributes of ours that still inherit from it, but that doesn't seem like it would cause a problem for anyone.

    For the message, I'd just tell them to implement IParameterDataSource. There are too many variables around what they may want to inherit from.

  2. added this to the 3.11 milestone on Apr 28, 2018
  3. mikkelbu commented on Jun 18, 2018

    @mikkelbu
    Member

    Sure @YuriyOborozhnyi. Just ask if you have any questions about the task. Edit: I've assigned the issue to myself to mark it as taken.

  4. self-assigned this
    on Jun 18, 2018
  5. mikkelbu commented on Jun 20, 2018

    @mikkelbu
    Member

    @YuriyOborozhnyi We can only assign issues to members of the project. Prior (approx. 1 year ago) we added each new contributor as a member of the project. The current approach is to assign a mentor/shepherd to non-members and then invite non-members to the project when they have contributed a couple of PRs (or otherwise been active within the project).

  6. mikkelbu commented on Jun 20, 2018

    @mikkelbu
    Member

    @YuriyOborozhnyi You are welcome, and sorry about the slow feedback 😄

  7. mikkelbu commented on Jun 25, 2018

    @mikkelbu
    Member

    @YuriyOborozhnyi Don't be sorry. Since we do this in our spare time I fully understand that sometimes issues progress slower than planned or than what we had hoped for (and with "we" I actually mean you and not us). I just glad that people are participating and helping out.

    I have also written my part of comments like "I thought I had time to do this", "I did not have time to do this today, but tomorrow..." 😄.

  8. mikkelbu commented on Jun 27, 2018

    @mikkelbu
    Member

    Thanks for the contribution @YuriyOborozhnyi. It is much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions