Copy/paste error in Assert.That documentation

[jnm2]

Every time an Assert.That overload has A ThrowsConstraint used in the test, it should be replaced with A Constraint expression to be applied to be more consistent with the other Assert.That overloads (and more truthful).

Also, the summary should be updated the same way.

nunit/src/NUnitFramework/framework/Assert.That.cs

Lines 175 to 181 in 5cfc6da

	/// <summary>
	/// Asserts that the code represented by a delegate throws an exception
	/// that satisfies the constraint provided.
	/// </summary>
	/// <param name="code">A TestDelegate to be executed</param>
	/// <param name="constraint">A ThrowsConstraint used in the test</param>
	public static void That(TestDelegate code, IResolveConstraint constraint)

[CharliePoole]

Doesn't the expression in the above example have to resolve to a throwsconstraint? If it doesn't, then you end up applying a constraint to the result of calling the delegate, which is void.

[jnm2]

Oh, I see. We don't require a ThrowsConstraint through. You could pass a custom contraint. And the delegate doesn't have to throw an exception. Besides Throws.Nothing, we might also be measuring the time.

Do you think we can be more specific than the changes I suggested?

[CharliePoole]

Maybe a "constraint expression that resolves to a constraint that can handle a TestDelegate". This is one of those things that could be a compiler error if constraints were fully generic.

[jnm2]

@CharliePoole TestDelegate would also work with a plain Is.Null or Is.NotNull. I'm not coming up with a valid way to say more than A Constraint expression to be applied.

[CharliePoole]

Only in a very limited definition of "work", however. :smile

I don't have any very strong opinion on this but it is interesting.

[MhdTlb]

@jnm2 I can take this one