ComparisonConstraints are allocating string on construction

[lahma]

While investigating our test suite's memory usage, NUnit also came up from some paths where a lot of parsed data was processed through loop that checked against LessThanOrEqualConstraint. If you look how all ComparisonConstraint inheritors are implemented, they all allocate Description when constructed even though I would presume it's not needed unless assertion fails?

nunit/src/NUnitFramework/framework/Constraints/GreaterThanOrEqualConstraint.cs

Lines 35 to 38 in 6f806c6

	public GreaterThanOrEqualConstraint(object expected) : base(expected)
	{
	Description = "greater than or equal to " + MsgUtils.FormatValue(expected);
	}

I would suggest that these would be either lazy evaluated or evaluated every time the getter is called, like for example in EqualConstraint:

nunit/src/NUnitFramework/framework/Constraints/EqualConstraint.cs

Lines 399 to 421 in 6f806c6

	public override string Description
	{
	get
	{
	System.Text.StringBuilder sb = new System.Text.StringBuilder(MsgUtils.FormatValue(_expected));
	if (_tolerance != null && !_tolerance.IsUnsetOrDefault)
	{
	sb.Append(" +/- ");
	sb.Append(MsgUtils.FormatValue(_tolerance.Amount));
	if (_tolerance.Mode != ToleranceMode.Linear)
	{
	sb.Append(" ");
	sb.Append(_tolerance.Mode.ToString());
	}
	}
	if (_comparer.IgnoreCase)
	sb.Append(", ignoring case");
	return sb.ToString();
	}
	}

[rprouse]

Looks like a good idea and an easy fix. Thanks for the examples.

[madetara]

Hello. I'd like to work on this issue. Need some time to go through all the contributing guidelines though.

[mikkelbu]

Hi @madetara
The issue is yours. I've assigned the issue to myself just to mark it as "taken", as we cannot assign issues to non-members. Here are the contributing guidelines and how to build build and run the tests (I personally prefer just to run build.ps1 -t Test). If you have any questions then just ask, and we will help you along 😄.

[madetara]

It seems I came up with good solution, but having troubles running tests, getting following error:
More than one build script specified.
Both via build.sh -t Test and build-mono-docker.ps1 -t Test

OS: Manjaro 17.1.12
Bash: 4.4.23
Docker: 18.06.1-ce
Mono: 5.14.0

P.S. Project builds via Rider with no problems, even though it's said that mono should crush

EDIT: Following command seem to work: buils.sh -SriptArgs '-t="Test"' maybe it's worth adding to building guide

[mikkelbu]

@madetara
I don't have access to a Linux box currently (and have not tried to build NUnit from another OS than Windows), but from the configurations of AppVeyor and Travis it looks like the script is called as
.\build.ps1 -Target Test from PowerShell and ./build.sh --target=Test from bash (or similar). Looking at the nunit-console I think that the = can be replaced with a space.

Can you see if it works, then I can update the building guide?

[madetara]

Yep, that works, thanks for the asnwer.

I'm now having another problem though, NuGetRestore fails with the following error:
error NU1603: nunitlite depends on NETStandard.Library (>= 2.0.2-servicing-26420-0) but NETStandard.Library 2.0.2-servicing-26420-0 was not found. An approximate best match of NETStandard.Library 2.0.2 was resolved.

[mikkelbu]

Hi @madetara
I'm not sure if I can help you with this. This sounds like the same problem as in https://bugs.archlinux.org/task/59274, so a "problem" with Arch Linux?
Do you get more (relevant) information if you run with Verbosity set to Diagnostic ?. Perhaps @CharliePoole can help you (as far as I can remember he shifted til Linux only development recently, but I guess that the "dotnet tooling" is different from Linux variant to Linux variant.