You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apparently individual arguments should not truncate when not specifying a truncation length, but they do. There is no test that covers this.
Line to be changed
Should be fragments.Add(new ArgumentFragment(index, 0));
The additional test is simple to add but to get the tests to run require some effort due to missing .Net frameworks/ .NET Core as well as an msbuild error.
@nunit/framework-team I want to make sure everyone agrees that this should be fixed, as I suggested to @tonyhallett on nunit/docs#360. It seems like a clear error to me.
Originally, all the class used a constant width of 40, which was changed so that there is no default limitation of length in the framework, but 40 was retained as a limit for each individual argument. The value 40 doesn't appear anywhere else.
I made the changes back in 2015, as well as originally creating the class, but I can't remember the reason, if I had one, to keep the intrinsic limit on {o}.
If the framework has no intrinsic limits, runners can still impose them by truncating the string. But there is no way for the runner to reconstruct the full argument if the framework truncates it.
Thought this could be a documentation issue - apparently not
Apparently individual arguments should not truncate when not specifying a truncation length, but they do. There is no test that covers this.
Line to be changed
Should be
fragments.Add(new ArgumentFragment(index, 0));
The additional test is simple to add but to get the tests to run require some effort due to missing .Net frameworks/ .NET Core as well as an msbuild error.
@CharliePoole Please can you have a look
The text was updated successfully, but these errors were encountered: