Skip to content

Sporadic GetResultIsNotCalledUntilContinued failure #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jnm2 opened this issue Jul 4, 2019 · 3 comments · Fixed by #3310
Closed

Sporadic GetResultIsNotCalledUntilContinued failure #3307

jnm2 opened this issue Jul 4, 2019 · 3 comments · Fixed by #3310
Assignees
@jnm2
Labels
closed:done pri:high
Milestone
3.13

Comments

@jnm2
Copy link
Contributor

jnm2 commented Jul 4, 2019

I've seen this a few times in CI builds:

1) Failed : NUnit.Framework.AwaitableReturnTypeTests("ReturnsCustomTask").GetResultIsNotCalledUntilContinued
GetResult was not called after the continuation passed to OnCompleted was invoked.
   at NUnit.Framework.AwaitableReturnTypeTests.GetResultIsNotCalledUntilContinued() in C:\projects\nunit\src\NUnitFramework\tests\AwaitableReturnTypeTests.cs:line 83
@jnm2 jnm2 added the pri:high label Jul 4, 2019
@jnm2 jnm2 self-assigned this Jul 4, 2019
@CharliePoole
Copy link
Member

Me too. Hope you can get rid of it.

@jnm2 jnm2 mentioned this issue Jul 4, 2019
Merged
@jnm2
Copy link
Contributor Author

jnm2 commented Jul 4, 2019

I'm still trying to repro, but in the meantime I'd like to get rid of the spin waits: #3310

@jnm2
Copy link
Contributor Author

jnm2 commented Jul 4, 2019

Ah, I bet it was as simple as the 1000 timeout being too short for CI. Added a commit in #3310 to increase to the standard 10_000.

@ChrisMaddock ChrisMaddock added this to the 3.13 milestone Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnm2 jnm2

Labels
closed:done pri:high
Projects
None yet
Milestone
3.13
Development

Successfully merging a pull request may close this issue.

Increase timeout for CI and use events rather than spin waits in tests jnm2/nunit
3 participants
@CharliePoole @ChrisMaddock @jnm2