Skip to content

Broken link in CHANGES.md #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dlebansais opened this issue Jul 21, 2019 · 4 comments · Fixed by #3326
Closed

Broken link in CHANGES.md #3324

dlebansais opened this issue Jul 21, 2019 · 4 comments · Fixed by #3326

Comments

@dlebansais
Copy link

The file ./CHANGES.md contains "https://github.com/nunit/dev/wiki/Core-Engine", and this link triggers my broken link detector when I install.

@mikkelbu
Copy link
Member

As far as I can tell the "core-engine" was removed based on this issue #793, but I cannot find any trace of the old documentation (as far as I can tell it was in a repository that no longer exists and was not migrated to the "docs"-repository, as the functionality was removed before this repository was created).

I'm happy to delete the following sentence from CHANGES.md (to reduce confusion and remove broken links)

See https://github.com/nunit/dev/wiki/Core-Engine for more information.

even though it is a bit stange to update old release notes. What do you think @nunit/framework-and-engine-team ?

@ChrisMaddock
Copy link
Member

Sounds sensible to me. 🙂

@jnm2
Copy link
Contributor

jnm2 commented Jul 21, 2019

Sure.

@rprouse
Copy link
Member

rprouse commented Jul 22, 2019

The core engine has been merged with the engine, so I think it makes sense to just clean up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants