SetUpFixture not being triggered when running tests using --testlist

[mcopjan]

NUnitLite 3.12.0 (.NET Standard 2.0)

I have some code which is loading configuration in SetUpFixture class. I have noticed that this code is not being triggered when tests are executed using --testlist parameter.

Steps to reproduce:
1] Create a SetUpFixture which does not belong to any namespace (will be always triggered)

using System;
using NUnit.Framework;

[SetUpFixture]
public class SetUpFixture
{
    public SetUpFixture()
    {
        Console.WriteLine("Hello from SetUpFixture.");
    }
}

2]Create a simple test

using System;
using NUnit.Framework;

namespace TestAutomation.Dashboard.Tests.Features
{
    public class DummyTest
    {
        [Test]
        public void TestSetUpFixture()
        {
            Console.WriteLine("Hello from the Test.");
        }
    }
}

• Execute using where expression:

• Executing using --testlist
  

As visible from the output above, when using --testlist there is no log message from the SetUpFixture.

[CharliePoole]

You should review the documentation for SetUpFixture. All the activity in a SetUpFixture takes place in methods with the [OneTimeSetUp] and [OneTimeTearDown] attributes. There is no particular guarantee that the constructor will be executed if there is no reason to construct the class.

The different behavior in the two situations seems odd to me, but since it relies on execution on non-guaranteed behavior (execution of the constructor) it's not totally surprising.

[mcopjan]

Thanks @CharliePoole, I will move my logic from constructor to OneTimeSetUp and report back.

[mikkelbu]

I just tried to reproduce the problem, and it also exists when the logic is moved to a method decorated with OneTimeSetUp. My guess is that the problem is due to the prefiltering and is essentially the same as #3356.

EDIT: My suspicion is correct. Downgrading NUnit to 3.10 (the release before prefiltering) makes the behaviour the same, so testlist invokes the prefilter, but the where clause do not.

[mcopjan]

@mikkelbu Unfortunately we cannot downgrade Nunit version (because of other external dependencies using Nunit >=3.12.0). Will the same fix for Nunit Adapter 3.15.1 be roll out for NunitLite please?

[mikkelbu]

@mcopjan The fix for the adapter was to "hide" the functionality behind a feature flag. I would rather have us solve the underlying problem. I've placed this issue in the milestone for the next release, but currently, I don't have much time to work on it.

[rprouse]

Resolved by #3679