Skip to content

Update nuspec file to mention support for NET Standard 2.0+ #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stevenaw opened this issue Oct 31, 2019 · 4 comments · Fixed by #3419
Closed

Update nuspec file to mention support for NET Standard 2.0+ #3411

stevenaw opened this issue Oct 31, 2019 · 4 comments · Fixed by #3419
Assignees
@stevenaw
Labels
closed:done good first issue help wanted is:bug pri:high
Milestone
3.13

Comments

@stevenaw
Copy link
Member

I think the nuspec file for nunit.dll needs to have the description updated to reflect current supported platforms. It mentions .NET Standard 1.4+ but I think the actual support is .NET Standard 2.0+.
https://github.com/nunit/nunit/blob/master/nuget/framework/nunit.nuspec#L21
@jnm2
Copy link
Contributor

jnm2 commented Nov 4, 2019

Oh, that's important. Would you be able to take care of it?

@jnm2 jnm2 added this to the 3.13 milestone Nov 4, 2019
@stevenaw
Copy link
Member Author

stevenaw commented Nov 4, 2019

Sure thing, I should be able to do this tonight

@jnm2
Copy link
Contributor

jnm2 commented Nov 4, 2019

Awesome. I didn't mean to rush you or anything. Only needs to be done before 3.13 ships.

@stevenaw stevenaw mentioned this issue Nov 5, 2019
Merged
@stevenaw
Copy link
Member Author

stevenaw commented Nov 5, 2019 •
edited
Loading

Not a problem, it's a pretty quick change and I had some time tonight. PR is open for review.
I left a comment in there about keeping (or not) the mention of .NET Core in the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenaw stevenaw

Labels
closed:done good first issue help wanted is:bug pri:high
Projects
None yet
Milestone
3.13
Development

Successfully merging a pull request may close this issue.

Update nuspec description for framework stevenaw/nunit
3 participants
@stevenaw @rprouse @jnm2