Skip to content

Backport .NET6 test infra + build improvements from #3984 onto v3.13 branch #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevenaw opened this issue Mar 1, 2022 · 4 comments
Closed

Comments

@stevenaw
Copy link
Member

stevenaw commented Mar 1, 2022

As noted by @manfred-brands (#4036 (comment))
We added .NET6 to our testing matrix on main in #3984 along with some nice build improvements to reduce duplication of specified runtime/library build targets. I think this could be a good candidate to backport to v3.13 as well as it will help keep the testing and tooling between the two consistent

@manfred-brands
Copy link
Member

@stevenaw As those were my changed, would you like me to create a PR for this or do we need to wait for consensus?

@stevenaw
Copy link
Member Author

stevenaw commented Mar 2, 2022

You are very welcome to take this on if you have time @manfred-brands , thanks! You would definitely be most familiar with what's needed.
I think this should be a fairly safe thing to commit to on 3.13 given we know there's going to be a future release and this would allow us to test against the latest LTS, but lets see if at least a second person from @nunit/framework-team or @nunit/core-team is in favour.

@rprouse rprouse added this to the 3.13.3 milestone Mar 15, 2022
@rprouse
Copy link
Member

rprouse commented Mar 20, 2022

@manfred-brands I'd like to get a release out before the end of the month. Do you think you can get this in? I'd be cool to merge post release though.

@manfred-brands
Copy link
Member

Sorry @rprouse I was waiting for someone to second the request as asked by @stevenaw. I missed you adding the milestone. Not sure if github creates notifications for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants