Skip to content

Cache method discovery by migrating PR 4034 to main #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stevenaw opened this issue Mar 7, 2022 · 2 comments · Fixed by #4133
Closed

Cache method discovery by migrating PR 4034 to main #4053

stevenaw opened this issue Mar 7, 2022 · 2 comments · Fixed by #4133
Assignees
@stevenaw
Labels
closed:done is:enhancement
Milestone
4.0

Comments

@stevenaw
Copy link
Member

stevenaw commented Mar 7, 2022

PR #4034 added caching of method lookups. It was merged to 3.13, we should consider also syncing it to main/v4
@stevenaw stevenaw changed the title Migrate PR 4034 to main Cache method discovery by migrating PR 4034 to main Mar 7, 2022
@stevenaw
Copy link
Member Author

stevenaw commented Mar 7, 2022 •
edited
Loading

We may want to wait until #4050 merges before doing this so that the Array.Empty<> usage in #4034 can be simplified

@stevenaw stevenaw added this to the 4.0 milestone Apr 22, 2022
@stevenaw stevenaw removed the blocked label May 4, 2022
@manfred-brands manfred-brands mentioned this issue Jun 11, 2022
Merged
@stevenaw
Copy link
Member Author

stevenaw commented Jun 11, 2022 •
edited
Loading

When doing this, we should also include the bugfix covered by #4104

@stevenaw stevenaw self-assigned this Jun 21, 2022
@stevenaw stevenaw mentioned this issue Jun 21, 2022
Merged
@stevenaw stevenaw mentioned this issue Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenaw stevenaw

Labels
closed:done is:enhancement
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Port caching of method discovery to main nunit/nunit
2 participants
@OsirisTerje @stevenaw