Type args are not deduced correctly for parameterized fixtures

[estrizhok]

NUnit 3.13.1

Consider the following test class (from your own codebase):

[Category("Generics")]
[TestFixture(100.0, 42)]
[TestFixture(42, 100.0)]
public class DeduceTypeArgsFromArgs<T1, T2>
{
    T1 t1;
    T2 t2;

    public DeduceTypeArgsFromArgs(T1 t1, T2 t2)
    {
        this.t1 = t1;
        this.t2 = t2;
    }

    [TestCase(5, 7)]
    public void TestMyArgTypes(T1 t1, T2 t2)
    {
        Assert.That(t1, Is.TypeOf<T1>());
        Assert.That(t2, Is.TypeOf<T2>());
    }
}

Expected type args:

1. System.Double, System.Int32
2. System.Int32, System.Double

Actual type args:

1. System.Double, System.Double
2. System.Double, System.Double

P.S. I fixed it (and wrote tests) but could not commit to a new branch in your repository so as I could make a pull request. How do I do that?

remote: Permission to nunit/nunit.git denied to estrizhok.
fatal: unable to access 'https://github.com/nunit/nunit.git/': The requested URL returned error: 403

[mikkelbu]

Hi @estrizhok
In order to make a PR you should.first clone the repository, the make a branch in the clone, and then create the PR against this repository

[stevenaw]

I can confirm this is happening. A simpler repro which should pass but instead fails on the second assertion:

[TestFixture(100.0, 42)]
public class DeduceTypeArgsFromArgs<T1, T2>
{
    T1 t1;
    T2 t2;

    public DeduceTypeArgsFromArgs(T1 t1, T2 t2)
    {
        this.t1 = t1;
        this.t2 = t2;
    }

    [Test]
    public void TestMyArgTypes()
    {
        Assert.That(t1, Is.TypeOf<double>());
        Assert.That(t2, Is.TypeOf<int>());
    }
}