Skip to content

Remove use of params for messages #4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OsirisTerje opened this issue Jul 10, 2023 · 0 comments
Closed

Remove use of params for messages #4415

OsirisTerje opened this issue Jul 10, 2023 · 0 comments
Labels
Breaking Change Indicates resolving the issue will be a breaking change and will require it to be in a major version closed:done is:deprecation Removing features
Milestone
4.0

Comments

@OsirisTerje
Copy link
Member

OsirisTerje commented Jul 10, 2023 •
edited
Loading

Ref issue #4413 and Issue #3936 - introduction of CallerArgumentExpressions (CAE).

Since we need to have the CAE at the end of the parameter list, we can't have the params there. The use of params for messages are now superseded by the use of string interpolation.

The analyzer should warn about this usage and suggest conversion to an interpolated string, see nunit/nunit.analyzers#562
@OsirisTerje OsirisTerje added this to the 4.0 milestone Jul 10, 2023
@OsirisTerje OsirisTerje mentioned this issue Jul 10, 2023
Closed
@OsirisTerje OsirisTerje added the Breaking Change Indicates resolving the issue will be a breaking change and will require it to be in a major version label Jul 14, 2023
@OsirisTerje OsirisTerje mentioned this issue Jul 15, 2023
Merged
@OsirisTerje OsirisTerje mentioned this issue Jul 24, 2023
Closed
@OsirisTerje OsirisTerje added is:deprecation Removing features and removed is:feature labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change Indicates resolving the issue will be a breaking change and will require it to be in a major version closed:done is:deprecation Removing features
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@OsirisTerje