Skip to content

Fix null message in internal static string? ExtendedMessage(string methodName, string? message, string actualExpression, string constraintExpression) #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OsirisTerje opened this issue Jul 24, 2023 · 2 comments · Fixed by #4435
Closed

Fix null message in internal static string? ExtendedMessage(string methodName, string? message, string actualExpression, string constraintExpression) #4432

OsirisTerje opened this issue Jul 24, 2023 · 2 comments · Fixed by #4435
Assignees
@manfred-brands
Labels
is:internal Internal fixes
Milestone
4.0

Comments

@OsirisTerje
Copy link
Member

Ref comment in PR #4430

The message comes from the _getExceptionMessageoverloads which are declared asFunc<string?>. Also there are some NUnit tests (e.g. LifeCycleAttributeTest) that pass in result.Messagewhich is also declaredstring?`.
If we want to change all that, I would do that in a separate PR.
This was referenced Jul 24, 2023
Closed
Merged
@manfred-brands
Copy link
Member

@OsirisTerje I started in this.

@OsirisTerje
Copy link
Member Author

@manfred-brands Awesome!

@manfred-brands manfred-brands mentioned this issue Jul 26, 2023
Merged
@OsirisTerje OsirisTerje added the is:internal Internal fixes label Oct 7, 2023
@OsirisTerje OsirisTerje added this to the 4.0 milestone Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manfred-brands manfred-brands

Labels
is:internal Internal fixes
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

All Assert messages must be non-null nunit/nunit
2 participants
@OsirisTerje @manfred-brands