Skip to content

Rename zip and remove source zip #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2017
Merged

Rename zip and remove source zip #1929

merged 2 commits into from
Jan 4, 2017

Conversation

ChrisMaddock
Copy link
Member

Relates to nunit/nunit-distribution#11. This one's optional, but general consensus seemed to be that it was a good idea.

This renames the framework zip to NUnit.Framework.{Version}, to avoid ambiguity. See general notes on nunit/nunit-distribution#11.

I also removed the source zip at the same time. We stopped distributing this previously in favour of GitHub's automated version, and the task wasn't hooked up to everything. The equivalent has already been removed in the console project.

@ChrisMaddock ChrisMaddock added this to the 3.6 milestone Dec 14, 2016
@CharliePoole
Copy link
Member

I'd prefer to keep the hyphen between the package name and version.

Also, while we are thinking about zips... we used to go to a lot of trouble to ensure that each zip had a single root folder named after the package itself, e.g. nunit.framework-1.2.3. Aren't we doing that any longer?

And while I'm at it 😄 are we abandoning the standard that distributed packages are named in lower case? I realize we have made a few exceptions over the years, so that too has become inconsistent. I just hate to see us kind of creep from one way of doing things to another, rather than just making a group decision.

@ChrisMaddock
Copy link
Member Author

Happy with hyphens, see nunit/nunit-distribution#11. Regarding the other points, we could do both - although neither seem to have been in place since back before 3.0. From a quick check, it looks like both would also need to be implemented across all repo's - adapter and console both seem to also use SentenceCase and no root folder in the zip.

I'd be tempted to say let's change the convention, and save ourselves some work in changing all the build scripts!

@CharliePoole
Copy link
Member

I guess when you keep making exceptions, it becomes unclear what the standard is or whether there is a standard. Let's see what @rprouse thinks.

@ChrisMaddock
Copy link
Member Author

Ok, change made as discussed on nunit/nunit-distribution#11 😄

@rprouse rprouse merged commit 8d99ac6 into master Jan 4, 2017
@rprouse rprouse deleted the rename-zip branch January 4, 2017 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants