Skip to content

Use high-quality icon for nuspecs #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2016
Merged

Use high-quality icon for nuspecs #1945

merged 1 commit into from
Dec 29, 2016

Conversation

ChrisMaddock
Copy link
Member

@ChrisMaddock ChrisMaddock added this to the 3.6 milestone Dec 29, 2016
@ChrisMaddock ChrisMaddock self-assigned this Dec 29, 2016
@CharliePoole CharliePoole merged commit 9c20c84 into master Dec 29, 2016
@ChrisMaddock ChrisMaddock deleted the nuget-icon branch December 29, 2016 18:26
@CharliePoole
Copy link
Member

@ChrisMaddock I merged this but the Travis build is failing. Two linux jobs fail. There seems to be an intermittent error in the messages we get for equal comparisons. It looks unrelated so I'm leaving this merged but you should take a look yourself to make sure it isn't due to any changes of yours.

@ChrisMaddock
Copy link
Member Author

Did you re-run? They all look passed to me?

@ChrisMaddock
Copy link
Member Author

ChrisMaddock commented Dec 29, 2016

Ah, I see - the master failed after merge. This is a semi-regular failure isn't it...I've always through it's an odd one to be sporadic! Only for the NET 3.5 framework too... I don't think changing the nuspec icon paths could have affected this - I'll rerun it now. 😄

1) Failed : NUnit.Framework.Constraints.EqualConstraintTests.FailsWithBadValues(double.PositiveInfinity,"Infinity")
  Expected string length 35 but was 62. Strings differ at index 13.
  Expected: "  Expected: 4\n  But was:  Infinity\n"
  But was:  "  Expected: 4 +/- 0.0050000000000000001d\n  But was:  Infinity\n"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants