Remove "Version 3" suffix from NUnitLite NuGet Package #2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm good with this. Does anyone else have issues with the rename? |
rprouse
approved these changes
Apr 24, 2017
|
IIRC the "NUnitlite" package is the old 1.0 release. I'll be on my computer in an hour where I can check further. |
|
This is therefore good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just spotted this today. The NUnit NuGet package was renamed "NUnit Version 3" -> "NUnit" with 3.0, the NUnitLite package should be consistent. Otherwise it creates weird display strings like:
NUnitLite Version 3 3.6.1This is just the display name, so shouldn't have any side effects.