Add portable-slow-tests to Cake file #2150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I caught this while porting from Portable to .NET Standard, but that work isn't ready ready. 👍 |
|
How were our tests passing before? |
|
MSBuild takes care of building project dependencies - so this was being built when the framework tests dll was being built. I don't know if that's the same for XBuild - portable isn't built there of course. Given we build everything else separately though - it seemed to make sense to correct this one. I imagine it's just a copy and paste error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are missing, spotted while working on #2119. Committing separately, as I'm at least temporarily abandoning #2119!