Revert accidental doc removal #2304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mikkelbu 🙂 |
|
@ChrisMaddock Should it not be an issue that is assigned to a milestone? (this is the only PR with a milestone AFAICT) |
|
If there's both Issue and PR, assign just the issue. If there's only a PR, assigning the PR is fine. The tool that generates the release notes doesn't mind which one is there, but of course we don't want any duplicates. 🙂 |
|
Understood 👍 |
|
Having an issue is only important for the humans, especially if there is a need to decide what to do. Also OOF you see a bug and don't plan to fix it in the next few minutes. |
|
Heh, it wasn't accidental. But 👍 |
|
Ah, ok! I thought it was an odd regex malfunction. ;-) Either way - it's documented now! |
People say that about me a lot. 😁 ;-) |
OmicronPersei
added a commit
to OmicronPersei/nunit
that referenced
this pull request
Jul 27, 2017
Revert accidental doc removal nunit@acdc547#diff-773ff02e2f8e671f005e32bcf2e9d03eL44 Merge pull request nunit#2304 from nunit/ChrisMaddock-patch-1 Revert accidental doc removal Tests now work, namespace issue was preventing building. Merge remote-tracking branch 'nunit-upstream/master' into issue-1151 Extended CollectionTally to keep track of both extra and missing items. Basic collection differences now displayed. Some test refactoring. Hopefully caught them all this time. Added test to ensure CollectionEquivalentConstraint returns a CollectionEquivalentConstraintResult. Fixed some broken tests. Add test to ensure that CollectionEquivalentConstraint makes use of new feature by default. Added test files to all test projects. Removed unnecessary include in csproj and removed unnecessary using statements in CollectionEquivalentConstraintResultTests. Cleaned up some of the tests, added one more. Added warning disable for linux builds.
OmicronPersei
added a commit
to OmicronPersei/nunit
that referenced
this pull request
Jul 27, 2017
Revert accidental doc removal nunit@acdc547#diff-773ff02e2f8e671f005e32bcf2e9d03eL44 Merge pull request nunit#2304 from nunit/ChrisMaddock-patch-1 Revert accidental doc removal Tests now work, namespace issue was preventing building. Merge remote-tracking branch 'nunit-upstream/master' into issue-1151 Extended CollectionTally to keep track of both extra and missing items. Basic collection differences now displayed. Some test refactoring. Hopefully caught them all this time. Added test to ensure CollectionEquivalentConstraint returns a CollectionEquivalentConstraintResult. Fixed some broken tests. Add test to ensure that CollectionEquivalentConstraint makes use of new feature by default. Added test files to all test projects. Removed unnecessary include in csproj and removed unnecessary using statements in CollectionEquivalentConstraintResultTests. Cleaned up some of the tests, added one more. Added warning disable for linux builds.
OmicronPersei
added a commit
to OmicronPersei/nunit
that referenced
this pull request
Jul 27, 2017
Revert accidental doc removal nunit@acdc547#diff-773ff02e2f8e671f005e32bcf2e9d03eL44 Merge pull request nunit#2304 from nunit/ChrisMaddock-patch-1 Revert accidental doc removal Tests now work, namespace issue was preventing building. Merge remote-tracking branch 'nunit-upstream/master' into issue-1151 Extended CollectionTally to keep track of both extra and missing items. Basic collection differences now displayed. Some test refactoring. Hopefully caught them all this time. Added test to ensure CollectionEquivalentConstraint returns a CollectionEquivalentConstraintResult. Fixed some broken tests. Add test to ensure that CollectionEquivalentConstraint makes use of new feature by default. Added test files to all test projects. Removed unnecessary include in csproj and removed unnecessary using statements in CollectionEquivalentConstraintResultTests. Cleaned up some of the tests, added one more. Added warning disable for linux builds.
OmicronPersei
added a commit
to OmicronPersei/nunit
that referenced
this pull request
Jul 28, 2017
Revert accidental doc removal nunit@acdc547#diff-773ff02e2f8e671f005e32bcf2e9d03eL44 Merge pull request nunit#2304 from nunit/ChrisMaddock-patch-1 Revert accidental doc removal Tests now work, namespace issue was preventing building. Merge remote-tracking branch 'nunit-upstream/master' into issue-1151 Extended CollectionTally to keep track of both extra and missing items. Basic collection differences now displayed. Some test refactoring. Hopefully caught them all this time. Added test to ensure CollectionEquivalentConstraint returns a CollectionEquivalentConstraintResult. Fixed some broken tests. Add test to ensure that CollectionEquivalentConstraint makes use of new feature by default. Added test files to all test projects. Removed unnecessary include in csproj and removed unnecessary using statements in CollectionEquivalentConstraintResultTests. Cleaned up some of the tests, added one more. Added warning disable for linux builds. Some cleaning up. Rebased off of upstream/master, fixed one error after merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another @oznetmaster special -acdc547#diff-773ff02e2f8e671f005e32bcf2e9d03eL44
#2296 seems to have caught something it couldn't.