Remove unused defines #2580
Merged
Remove unused defines #2580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
reviewed
Nov 28, 2017
| namespace NDesk.Options | ||
| #else | ||
| namespace Mono.Options | ||
| #endif |
There was a problem hiding this comment.
The history here impressed me when I ran into it when helping with issue-2331.
jnm2
approved these changes
Nov 28, 2017
|
Guess we're waiting on CI to merge stuff. I'm going to do the csproj stuff in the list (https://github.com/orgs/nunit/teams/framework-and-engine-team/discussions/3) after this PR is merged. Gotta call it a night– 🍾 + my sleep schedule has been repaired 😁– but I'll be back at it tomorrow evening most likely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NUNIT_FRAMEWORK and NUNITLITE defines are no longer used, so removing from the project files.