Skip to content

Fix flakey test #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2017
Merged

Fix flakey test #2622

merged 1 commit into from
Dec 16, 2017

Conversation

ChrisMaddock
Copy link
Member

Just hit a test failure because two tests were trying to access Test1.txt.

To fix this, I added an overload to the TestFile utility which uses Path.GetTempFileName() when the file name doesn't matter. (It then turned out the actual file name didn't matter in any case where TestFile was used.

@ChrisMaddock ChrisMaddock added this to the 3.10 milestone Dec 16, 2017
@ChrisMaddock ChrisMaddock self-assigned this Dec 16, 2017
CharliePoole
CharliePoole approved these changes Dec 16, 2017
View reviewed changes
Copy link
Member

@CharliePoole CharliePoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix to me. I'm surprised that the conflict came up. Was it between separate fixtures?

jnm2
jnm2 approved these changes Dec 16, 2017
View reviewed changes
Copy link
Contributor

@jnm2 jnm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It was bothering me too.

@jnm2 jnm2 merged commit 3ed68a1 into master Dec 16, 2017
@jnm2 jnm2 deleted the testfix branch December 16, 2017 16:44
@ChrisMaddock
Copy link
Member Author

@CharliePoole - Yes, FileOrDirectoryExistsConstraintTests and FileAssertTests. I don't think it's anything new, maybe I'm just unlucky today. ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharliePoole CharliePoole CharliePoole approved these changes

@jnm2 jnm2 jnm2 approved these changes

Assignees

@ChrisMaddock ChrisMaddock

Labels
is:bug
Projects
None yet
Milestone
3.10
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisMaddock @CharliePoole @jnm2