NUnitLite: Add support for --nocolor option #2711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hazzik! Is there any way we can get a test guaranteeing this behavior? |
|
@jnm2 I was thinking about this, but I'm not experienced with the NUnit's internal tests suit. Also, I was unable to find the suitable test suite to put this additional test into. Any suggestions welcome. |
jnm2
approved these changes
Feb 17, 2018
CharliePoole
approved these changes
Feb 17, 2018
There was a problem hiding this comment.
Makes sense to me. I wouldn't ask for a test here but @hazzik might have simply stated "The --nocolor option was being ignored. I verified that it now works." We usually trust what people tell us." 😄
Anyway, the code matches what the nunit3-console runner does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.