Avoid treating warnings as errors inside the IDE #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
approved these changes
Feb 28, 2018
There was a problem hiding this comment.
I've sort of wanted to do this, especially after @OmicronPersei wanted to write the XML docs last instead of first.
jnm2
reviewed
Feb 28, 2018
| <PropertyGroup Condition="'$(BuildingInsideVisualStudio)' != 'true'"> | ||
| <!-- Ideally this is always enabled, but that tends to hurt developer productivity --> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
My preference would have been to wait until two properties shared the condition before adding a new property group:
<Features>strict</Features>
+
+ <!-- Ideally this is always enabled, but that tends to hurt developer productivity -->
+ <TreatWarningsAsErrors Condition="'$(BuildingInsideVisualStudio)' != 'true'">true</TreatWarningsAsErrors>
+
<SignAssembly>true</SignAssembly>But not important.
There was a problem hiding this comment.
I tend to treat this like a functional unit, which can be copied to other projects as needed. I'll move it if you want me to move it; let me know the decision.
There was a problem hiding this comment.
There's no problem with it, just curiosity!
|
AppVeyor timed out executing the tests. I've restarted it. |
|
Thanks Sam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps improve developer inner loop efficiency by revealing but not demanding attention for warnings that occur during normal iterative development. Anything missed will still be caught by the CI and command line builds.
💡 Please do not rebase or squash this pull request on merge.