Use longer BusyExecIdle to avoid CI failures #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
commented
Apr 28, 2018
|
|
||
| Assert.That(() => sb.ToString(), Is.EqualTo("BusyExecIdle").After(200)); | ||
| if (!countdown.Wait(10000)) Assert.Fail("Timed out."); |
There was a problem hiding this comment.
If I had just changed After, we would have an unnecessary 10 second wait on success. (I also avoid [Timeout] on tests when possible because thread aborts introduce inherent unreliability.)
There was a problem hiding this comment.
Would this work using the polling functionality of DelayedConstraint? (E.g. After(10000,200))
There was a problem hiding this comment.
Seems to work great, thanks!
jnm2
force-pushed
the
jnm2/fix_busyexecidle_timeout
branch
from
efda95b to
4e86b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2831