Skip to content

Add tests for use of ApartmentState.Unknown in RequiresThreadAttribute#3105

Merged
mikkelbu merged 2 commits intomasterfrom
issue-3042b
Dec 5, 2018
Merged

Add tests for use of ApartmentState.Unknown in RequiresThreadAttribute#3105
mikkelbu merged 2 commits intomasterfrom
issue-3042b

Conversation

@ChrisMaddock
Copy link
Member

Tests for #3058. I wasn't sure of behaviour of myself, so wrote a test to check that, and it made sense to keep it!

Given that ApartmentAttribute has the same behaviour, I also added a test in the same format, and remove the previous test which tested at a lower level, for consistencies sake.

@ChrisMaddock ChrisMaddock self-assigned this Dec 5, 2018
@ChrisMaddock ChrisMaddock added this to the 3.12 milestone Dec 5, 2018
mikkelbu
mikkelbu previously approved these changes Dec 5, 2018
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM expect for one problem

Co-Authored-By: ChrisMaddock <chrismaddock@live.co.uk>
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikkelbu mikkelbu merged commit fe1c9fb into master Dec 5, 2018
@mikkelbu mikkelbu deleted the issue-3042b branch December 5, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants