Skip to content

Make tests more tolerant #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2019
Merged

Make tests more tolerant #3159

merged 1 commit into from
Feb 7, 2019

Conversation

mikkelbu
Copy link
Member

@mikkelbu mikkelbu commented Feb 7, 2019

We no longer expect an exact match, only a matching beginning and end.

Fixes #3156

@mikkelbu mikkelbu added this to the 3.12 milestone Feb 7, 2019
CharliePoole
CharliePoole approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@CharliePoole CharliePoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mikkelbu mikkelbu merged commit 2512649 into master Feb 7, 2019
@mikkelbu mikkelbu deleted the more-tolerant-tests-in-UnexpectedExceptionTests branch February 7, 2019 22:19
@jnm2
Copy link
Contributor

jnm2 commented Feb 7, 2019

Thanks, Mikkel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharliePoole CharliePoole CharliePoole approved these changes

Assignees
No one assigned
Labels
awaiting:review closed:done
Projects
None yet
Milestone
3.12
Development

Successfully merging this pull request may close these issues.

UnexpectedExceptionTests should tolerate Mono on Azure DevOps Ubuntu
4 participants
@mikkelbu @jnm2 @CharliePoole @rprouse