Skip to content

Fix logging #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2019
Merged

Fix logging #3211

merged 2 commits into from
Apr 25, 2019

Conversation

ChrisMaddock
Copy link
Member

See nunit/nunit-console#612. There was only this one case to fix on the framework. 🙂

mikkelbu
mikkelbu reviewed Apr 21, 2019
View reviewed changes
@mikkelbu
Copy link
Member

I've created #3212 to solve the problem with the Linux build on Travis.

@ChrisMaddock
Copy link
Member Author

Thanks Mikkel, changes made. 😄

mikkelbu
mikkelbu approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Ps. I'm forcing a rebuild on Azure and Travis will be solved by a rebase on master.

@ChrisMaddock ChrisMaddock merged commit 51f02de into master Apr 25, 2019
@ChrisMaddock ChrisMaddock deleted the ChrisMaddock-patch-2 branch April 25, 2019 20:23
@ChrisMaddock ChrisMaddock added this to the 3.12 milestone Apr 25, 2019
@ChrisMaddock ChrisMaddock self-assigned this Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

@jnm2 jnm2 jnm2 approved these changes

Assignees

@ChrisMaddock ChrisMaddock

Labels
closed:done
Projects
None yet
Milestone
3.12
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisMaddock @mikkelbu @jnm2