RawInt32() can't use Next since the maximum is always exclusive and it would never return int.MaxValue#3251
Merged
jnm2 merged 1 commit intonunit:masterfrom May 21, 2019
Merged
Conversation
…t would never return int.MaxValue
jnm2
force-pushed
the
fix_excluded_int_maxvalue
branch
from
c3c1bdc to
9de8a8b
Compare
oznetmaster
approved these changes
May 21, 2019
Contributor
oznetmaster
left a comment
oznetmaster
left a comment
There was a problem hiding this comment.
I did it explicitely, but this works :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3241 (comment)
/cc @oznetmaster, @CharliePoole