Skip to content

CheckString should not be a generic method #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2019
Merged

CheckString should not be a generic method #3304

merged 1 commit into from
Jul 6, 2019

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Jul 4, 2019

No description provided.

@jnm2 jnm2 requested a review from a team July 4, 2019 17:38
mikkelbu
mikkelbu approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikkelbu mikkelbu merged commit fca0221 into nunit:master Jul 6, 2019
@mikkelbu mikkelbu added this to the 3.13 milestone Jul 6, 2019
@jnm2 jnm2 deleted the should_not_be_generic branch July 7, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
closed:done is:refactor
Projects
None yet
Milestone
3.13
Development

Successfully merging this pull request may close these issues.
2 participants
@jnm2 @mikkelbu