Remove unused methods #3305
Merged
Remove unused methods #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
commented
Jul 4, 2019
| @@ -568,7 +568,7 @@ public class AdhocContext : TestExecutionContext | |||
| public AdhocContext() | |||
| { | |||
| var type = GetType(); | |||
| var method = type.GetMethod("AdhocTestMethod", BindingFlags.NonPublic | BindingFlags.Instance); | |||
| var method = type.GetMethod(nameof(AdhocTestMethod), BindingFlags.NonPublic | BindingFlags.Instance); | |||
There was a problem hiding this comment.
This lets ReSharper know that AdhocTestMethod is not unused.
jnm2
force-pushed
the
remove_unused_methods
branch
from
0f272ce to
a6cb061
Compare
|
Note to self: https://github.com/nunit/nunit/compare/master...jnm2:refactor_provider_cache?expand=1 depends on this |
|
@ChrisMaddock Do you think we should remove the |
|
Can do...I was just being lazy. 🤷♂️😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(None of these changes can be detected by users of the NUnit library.)