Skip to content

Drop netstandard1.4 and stop testing on end-of-life versions of .NET Core #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 9, 2019

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Sep 29, 2019

Related to #3320.

The .NET Standard 1.4 build is gone and the .NET Standard 2.0 build is no longer tested on .NET Core 2.0 which is out of support. Instead, it is tested on .NET Core 2.1, 2.2, and 3.0.

@jnm2 jnm2 force-pushed the move_targets branch 17 times, most recently from 02fb49c to 5a89f1d Compare October 3, 2019 23:47
@jnm2
Copy link
Contributor Author

jnm2 commented Oct 4, 2019

@rprouse Did you remove the Travis validation build, or is Travis maybe not responding to webhooks right now? I started getting only four checks in the last few updates to this PR, but I can start builds manually.

@jnm2
Copy link
Contributor Author

jnm2 commented Oct 7, 2019

I actually cannot figure out how to get Ubuntu on Travis to work without a large amount of further effort.

Tool 'cake.tool' (version '0.35.0') was successfully installed.
dotnet-cake: command not found

@rprouse Can you confirm whether we are dropping Travis? If so, I may as well delete the yaml because it won't run in its current state in this branch.

@CharliePoole
Copy link
Member

I use the cake tool for my Travis builds of TestCentric. My script allows for the fact that the tool is installed in a hidden subdirectory of your home directory.

See... https://github.com/TestCentric/testcentric-gui/blob/master/.travis.yml#L18

@jnm2
Copy link
Contributor Author

jnm2 commented Oct 8, 2019

That's the same line I started with, I think. Can you see a difference, excluding the latest commit?

@CharliePoole
Copy link
Member

CharliePoole commented Oct 8, 2019 via email

@rprouse
Copy link
Member

rprouse commented Oct 9, 2019

I removed Travis as a required build, but I don't think I removed it completely. I'm not sure why it isn't showing up. I'd be fine with dropping it though since we are building Linux on Azure DevOps and that has been much more reliable than Travis.

rprouse
rprouse previously approved these changes Oct 9, 2019
Copy link
Member

@rprouse rprouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnm2 jnm2 marked this pull request as ready for review October 9, 2019 18:24
@jnm2 jnm2 requested a review from rprouse October 9, 2019 18:24
@jnm2
Copy link
Contributor Author

jnm2 commented Oct 9, 2019

@rprouse I deleted the Travis file like I mentioned above because leaving it alone would have still left it broken, but I can do something else if you prefer!

@jnm2 jnm2 merged commit 46f8b2a into nunit:master Oct 9, 2019
@jnm2 jnm2 deleted the move_targets branch October 9, 2019 20:18
@jnm2 jnm2 added this to the 3.13 milestone Nov 7, 2019
mikkelbu added a commit that referenced this pull request Jan 16, 2021
Travis CI builds were made optional in #3195 and removed in #3383, but some
references to Travis was still left in the code-base.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants