Azure CI: Still publish test results on failure #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisMaddock
force-pushed
the
issue-3414
branch
from
c354e38 to
28742d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while looking at #3414, currently if any tests fail, Azure doesn't upload the test results. I think this will fix it - pushing this while CI is still failing to test! Edit: Checked, it did. 👍
Unfortunately it looks like Azure currently only runs on PR's and not branches, so I need a PR to test this. I'm not sure why that is - @rprouse - can you check the repo settings that Azure is getting notified on
pushas well aspull_request, please? Should be under Settings > Webhooks(Edit: I've found I can manually kick off branch builds, which is ok. Maybe this is 'behaviour as intended'.)
CI will be fixed after merging #3416