Skip to content

Annotate ITestData and implementations - #3488

Merged
rprouse merged 8 commits into
nunit:masterfrom
jnm2:annotate_test_data
Mar 5, 2020
Merged

Annotate ITestData and implementations#3488
rprouse merged 8 commits into
nunit:masterfrom
jnm2:annotate_test_data

Conversation

@jnm2

@jnm2 jnm2 commented Mar 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is a central point around which a lot of interfaces and implementations turn.
Contributes to #3376.

Commits

Cleanup

  1. Two files had line endings that didn't match

Annotation

  1. Annotate ITestData and implementations
  2. Enable NRTs for usages of ITestData to validate annotations

Fix

  1. Fix NUnit crash found by nullability warnings

Refactoring

  1. Always initialize TestParameters.Arguments because past behavior is inconsistent with ITestData usage
  2. Move TestMethod.NoArguments to TestParameters.NoArguments
  3. Refactor InitializeArguments into a more analysis-friendly constructor (fixes remaining warnings)

Improvement

  1. Add null guards that should have been present anyway to fix warnings in VS prior to 16.5

@jnm2
jnm2 requested a review from a team March 3, 2020 00:12
@jnm2
jnm2 force-pushed the annotate_test_data branch from f804d15 to 8055198 Compare March 3, 2020 00:34
rprouse
rprouse previously approved these changes Mar 3, 2020
View reviewed changes

@rprouse rprouse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on build of your latest push.

Comment thread src/NUnitFramework/framework/Internal/PropertyBag.cs
@jnm2
jnm2 force-pushed the annotate_test_data branch 2 times, most recently from 58d9d25 to a841e86 Compare March 3, 2020 01:11
jnm2
jnm2 commented Mar 3, 2020
View reviewed changes
Comment thread src/NUnitFramework/framework/Internal/TestParameters.cs Outdated
@jnm2
jnm2 force-pushed the annotate_test_data branch from a841e86 to 0f68126 Compare March 3, 2020 01:40
@jnm2
jnm2 force-pushed the annotate_test_data branch from 0f68126 to 1e3dc54 Compare March 3, 2020 02:05
@jnm2
jnm2 requested a review from rprouse March 3, 2020 02:09
@jnm2 jnm2 linked an issue Mar 3, 2020 that may be closed by this pull request
Nullable Reference Types annotations. Fixed by team through multiple PRs. #3376
Closed
@jnm2 jnm2 mentioned this pull request Mar 3, 2020
Merged
@jnm2 jnm2 removed a link to an issue Mar 3, 2020
Nullable Reference Types annotations. Fixed by team through multiple PRs. #3376
Closed
rprouse
rprouse approved these changes Mar 5, 2020
View reviewed changes

@rprouse rprouse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's not worry about the LF issue. Yes, Git is supposed to take care of it normally, but occasionally someone has git configured wrong and it doesn't and gets in somehow...

@rprouse
rprouse merged commit de5e0b1 into nunit:master Mar 5, 2020
@jnm2
jnm2 deleted the annotate_test_data branch March 5, 2020 01:49
@jnm2 jnm2 linked an issue Mar 5, 2020 that may be closed by this pull request
Nullable Reference Types annotations. Fixed by team through multiple PRs. #3376
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rprouse rprouse rprouse approved these changes

Assignees

No one assigned

Labels

awaiting:review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nullable Reference Types annotations. Fixed by team through multiple PRs.

2 participants

@jnm2 @rprouse