Conversation
stevenaw
approved these changes
Mar 15, 2020
Member
stevenaw
left a comment
stevenaw
left a comment
There was a problem hiding this comment.
Thanks @jnm2 this looks like a good change to have caught. I've tried filtering the PR to exclude whitespace and it shows that only whitespace changes have occurred (+ a BOM in ObjectToStringComparer ?). https://github.com/nunit/nunit/pull/3497/files?w=1
I'm not sure if I'm able to approve, but I don't see any issues with this as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone committed CRLF to the repository (they must have been on Windows and not had the typical
core.autocrlf = true).This results in VS prompts to fix mixed line endings if you edit any of these files, but VS then turns them all to CRLF which Git ignores when
core.autocrlf = true. So the problem is never resolved.Before this change: these files show up with primarily LF endings in new clones on Windows with
core.autocrlf = truewith a few CRLFs thrown in.After this change: these files show up with CRLF endings in new clones on Windows with
core.autocrlf = true.