ValueTuple tests now running if not targeting NET35 #3506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkelbu
approved these changes
Mar 19, 2020
|
Good catch, @stevenaw! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value tuple tests were setup to only run for NET45. Seems like they pass for me in the tests as far back as NET40, due to the inclusion of
System.ValueTupleas a test dependency. This PR switches up the conditional compilation so that they run#if !NET35instead of the previous#if NET45.I'm unsure if it can be expanded further so that the ValueTuple + Tuple tests are run on NET35 too.