Avoid using a culture-sensitive EndsWith in common code #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing a similar issue to nunit#1555, due to TupleComparer and ValueTupleComparer (in the NUnitEqualityComparer chain) calling into TypeHelper. (The impact for NodaTime is that tests on Linux in en-GB take 5-6 times as long as they should. We perform a lot of equality comparisons which get as far as EquatablesComparer in the chain.) It would be good to take a complete audit of StartsWith and EndsWith calls (and maybe even have a Roslyn-based unit test to make sure that any culture-sensitive calls are deliberately so), but I don't have the expertise to make the calls for other parts of the codebase. I'm pretty confident about this one :)
|
Looks good - thanks! 😄 |
This one thing I've wanted to address. I filed #3588 and suggested Fxcop Analyzers. Roslyn-based unit tests are great, but I would only find out about the test failure after submitting a PR and seeing CI fail. Analyzers are nice and immediate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a similar issue to #1555, due to TupleComparer and
ValueTupleComparer (in the NUnitEqualityComparer chain) calling into
TypeHelper.
(The impact for NodaTime is that tests on Linux in en-GB take 5-6
times as long as they should. We perform a lot of equality
comparisons which get as far as EquatablesComparer in the chain.)
It would be good to take a complete audit of StartsWith and EndsWith
calls (and maybe even have a Roslyn-based unit test to make sure
that any culture-sensitive calls are deliberately so), but I don't
have the expertise to make the calls for other parts of the
codebase. I'm pretty confident about this one :)