Reduce memory overhead of TestNameGenerator #3594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces memory overhead through two main improvements:
StringBuilder
by passing the top-levelStringBuilder
instance inTestNameGenerator
down into the differentNameFragment
sNameFragment.GetDisplayString
by convertingobject arg
into a primitive type (when possible) before comparing it to another primitiveThis is a bit of an implementation of the approach suggested in #3498 , though these changes happen to be fully encapsulated within this particular class with no public/internal method signature changes.
Benchmarks
View Results
View Code