Fix exception under blazor 5 #3647
Conversation
| testAssembly.Properties.Set(PropertyNames.ProcessId, System.Diagnostics.Process.GetCurrentProcess().Id); | ||
| try | ||
| { | ||
| testAssembly.Properties.Set(PropertyNames.ProcessId, System.Diagnostics.Process.GetCurrentProcess().Id); |
There was a problem hiding this comment.
Also starting in .NET 5, we should use the much less wasteful Environment.ProcessId. Do you know if Blazor still implements Environment.ProcessId to throw the same exception? If it doesn't throw an exception, we maybe want to add #if NET5_0 and use it in this PR to address Blazor 5.
There was a problem hiding this comment.
I guess we could also call https://docs.microsoft.com/en-us/dotnet/api/system.operatingsystem.isbrowser?view=net-5.0 inside the #if NET5_0 section even if Environment.ProcessId does throw, rather than catching an exception.
There was a problem hiding this comment.
I think I would prefer that solution, as I think we should avoid catching exceptions with empty error handlers if it is possible.
See https://devblogs.microsoft.com/dotnet/the-future-of-net-standard/#dealing-with-apis-that-are-unsupported-in-blazor-webassembly