Update internal string comparisons to use Ordinal when safe #3770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenaw
changed the title
stevenaw
force-pushed
the
3588/ordinal-string-comparisons
branch
from
ddaee9f to
aa65adf
Compare
stevenaw
changed the title
Co-authored-by: Mikkel Nylander Bundgaard <mikkelbu@users.noreply.github.com>
Member
Author
|
Oh, thanks @mikkelbu ! Using the char overload makes sense, I'm not sure how I missed that the first time |
Member
Author
|
@mikkelbu Thanks again for your review. I've tried updating the single-length string StartsWith/EndsWith to use the char overload, but I think that's only a netstandard 2.1+ API. I receive a compiler error on the current build targets of net45 + netstandard2. |
Member
|
@stevenaw You are right (just took at look at the documentation). I'll merge this now. Thanks for the contribution 👍 |
This was referenced Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3588
This PR tackles the low-hanging fruit of StartsWith/EndsWith/Contains of string comparisons within the framework. It focuses on cases where the argument is a string literal with all characters lying within the standard ASCII range.
The majority of the cases deal with either: