Repository navigation
Add formatter for DictionaryEntry - #3778
Merged
Merged
Conversation
Member
|
Looks good but can you add a unit test for this? |
Add corresponding unit test
manfred-brands
force-pushed
the
dictionaryentry_formatter
branch
from
February 28, 2021 00:33
e01fab1 to
da73c34
Compare
Member
Author
|
@rprouse Done. I had to rebase to fix a merge conflict as I original had branched off 'release' iso 'master'. |
mikkelbu
approved these changes
Feb 28, 2021
mikkelbu
left a comment
mikkelbu
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for yet another contribution @manfred-brands 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3718