Skip to content

Remove AreEqual methods with nullable numeric arguments #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2021
Merged

Remove AreEqual methods with nullable numeric arguments #3780

merged 1 commit into from
Feb 28, 2021

Conversation

Antash
Copy link
Contributor

@Antash Antash commented Feb 27, 2021

Closes #3449

jnm2
jnm2 approved these changes Feb 28, 2021
View reviewed changes
Copy link
Contributor

@jnm2 jnm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done!

@jnm2 jnm2 requested a review from a team February 28, 2021 00:16
mikkelbu
mikkelbu approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution @Antash 👍 . I'll merge it in now.

@mikkelbu mikkelbu merged commit 5748eab into nunit:master Feb 28, 2021
@mikkelbu mikkelbu added this to the 4.0 milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

@jnm2 jnm2 jnm2 approved these changes

Assignees
No one assigned
Labels
awaiting:review
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Assert.AreEqual overloads for nullable double are not useful
3 participants
@Antash @mikkelbu @jnm2