Skip to content

Remove AreEqual methods with nullable numeric arguments - #3780

Merged
mikkelbu merged 1 commit into
nunit:masterfrom
Antash:issue-3449
Feb 28, 2021
Merged

mikkelbu merged 1 commit into
nunit:masterfrom
Antash:issue-3449

Conversation

@Antash

@Antash Antash commented Feb 27, 2021

Copy link
Copy Markdown
Contributor

Closes #3449

@jnm2 jnm2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done!

@jnm2
jnm2 requested a review from a team February 28, 2021 00:16

@mikkelbu mikkelbu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution @Antash 👍 . I'll merge it in now.

@mikkelbu
mikkelbu merged commit 5748eab into nunit:master Feb 28, 2021
@mikkelbu mikkelbu added this to the 4.0 milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assert.AreEqual overloads for nullable double are not useful

3 participants