Add GitHub Actions to build on Windows, Linux and Mac #3819
Conversation
|
This is looking good now. Marking ready for review and will make Required once it is merged. |
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Build and Test | ||
| run: .\build.ps1 --target=Test --test-run-name=Windows |
There was a problem hiding this comment.
Any reason why you not use 'dotnet cake' to match the other two OS?
| pull_request: | ||
| branches: | ||
| - master | ||
| - release | ||
| - 'v3.13-dev' |
There was a problem hiding this comment.
Is there any reason to block CI from running if there was ever a pull request to another branch?
There might be other better-looking ways to do it, but pull_request: by itself with nothing following it enables the pull request trigger without putting filters on it. Maybe branches: [ '*' ] underneath if that looks too weird.
There was a problem hiding this comment.
You are probably right. I might change this in my next PR.
There was a problem hiding this comment.
I wonder if pull_request with no : would have worked.
There was a problem hiding this comment.
if there was ever a pull request to another branch?
It sounds unusual, but I've contributed directly to the topic branches of another person's PRs on GitHub. PR inception. I've also contributed to a compiler feature branch which is not something NUnit currently does.
|
One thing I'd like to do eventually is add binlog artifacts. That makes it easy to drop into https://msbuildlog.com (the F12 developer tools of MSBuild) if you have it installed to diagnose weird CI issues if they come up. It captures all environment variables though, so it's not good to expose public artifacts if there are decrypted secrets in there. Here's what it looks like to create binlogs (three of them in this case): https://github.com/shouldly/shouldly/blob/master/build.ps1#L15-L29 And upload them: https://github.com/shouldly/shouldly/blob/037a2b9c118aa266a84988d9adf0301c4ca1ad5a/.github/workflows/CI.yml#L29-L34 |
|
@manfred-brands thanks for the review. I apologize, I mis-tagged you, but I appreciate your help 👍🏻 |
|
Just thought of one more thing to recommend: env:
DOTNET_NOLOGO: true |
Fixes #3812
Currently just builds on all three platforms and saves the packages from Windows. It does not publish the packages to any NuGet package feed. In the future, we may do that.