Remove deprecated code #3836
Merged
Remove deprecated code #3836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rprouse
commented
Apr 23, 2021
| @@ -381,11 +381,18 @@ private static bool IsNetCore_Internal() | |||
| } | |||
| #endif | |||
|
|
|||
| private static bool IsRuntimeTypeName(string name) | |||
| private static RuntimeType ParseRuntimeType(string s) | |||
There was a problem hiding this comment.
This is the only new code. Runtime types are often passed in as strings and we allowed "NET" and "NetFramework". With the removal of the Net enum value, this no longer worked.
I'll likely clean this up more when I work on the PlatformAttribute, but this will do for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3769
I checked each of the obsolete classes, properties and method by searching GitHub for usages with a search like
Assert.That extension:cs in:fileAs a reference,
Assert.Thatis used 454K times,Assert.AreEqual1.691 million times and[TestFixture]2.289 million times.Based on the low usage of all of this code, I wonder if we can apply the same technique to some of the other classes that we want to make internal or possibly remove?
Types
AssertionHelper Type - Couldn't find usages, removed.
FileExistsConstraint type - Unused
DebugWriter type - Unused
DataAttribute type - Unused
List type - Only a few instance found in repos that haven't been updated in a long time
ListMapper type - Only found in repos using NUnit 2 and forks of NUnit 3
Members
DictionaryContainsKeyConstraint - Usages are hard to search for, but still agree with the deprecation
String Starting/Containing/Ending/Matching functions (replaced by StartsWith/Contains/EndsWith/Matches overloads)
RuntimeType - Interstingly, I couldn't even find recent usages of
RuntimeTypeCollectionContainsConstraint - Only used in NUnit forks?
Timeout Command - I only found one valid usage of this and left an issue to update it.
WorkItemBuilder - This is used by Saucery by @agray. I can't find other usages, but I will leave it for that project. I am removing the deprecation. Andrew, when this PR is merged, you should check that you aren't using anything else that I removed.
SimpleWorkItem - I can't find usages and the other constructor is available
NUnitEqualityComparer - Around 400 usages, all look to be old forks of NUnit
NUnitLite OptionSet