Skip to content

Changed summary comments on Warn.If overloads to correctly reflect… #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2021
Merged

Changed summary comments on Warn.If overloads to correctly reflect… #3845

merged 1 commit into from
Apr 30, 2021

Conversation

hyp-do
Copy link
Contributor

@hyp-do hyp-do commented Apr 30, 2021 •
edited by mikkelbu
Loading

Fixes #3811

that it asserts false and warns if true

@dnfadmin
Copy link

dnfadmin commented Apr 30, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

mikkelbu
mikkelbu approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've triggered the build and also changed the first description, so that it auto-closes #3811 when merged to master.

@mikkelbu
Copy link
Member

Merging this now. Thanks for the contribution @hyp-do 👍

@mikkelbu mikkelbu merged commit baf90c0 into nunit:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect summary comments on Warn.If overloads
3 participants
@hyp-do @dnfadmin @mikkelbu