Skip to content

Changed summary comments on Warn.If overloads to correctly reflect… - #3845

Merged
mikkelbu merged 1 commit into
nunit:masterfrom
hyp-do:fix-warnif-summary
Apr 30, 2021
Merged

mikkelbu merged 1 commit into
nunit:masterfrom
hyp-do:fix-warnif-summary

Conversation

@hyp-do

@hyp-do hyp-do commented Apr 30, 2021 •

Copy link
Copy Markdown
Contributor

Fixes #3811

that it asserts false and warns if true

@dnfadmin

dnfadmin commented Apr 30, 2021 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@mikkelbu mikkelbu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've triggered the build and also changed the first description, so that it auto-closes #3811 when merged to master.

@mikkelbu

Copy link
Copy Markdown
Member

Merging this now. Thanks for the contribution @hyp-do 👍

@mikkelbu
mikkelbu merged commit baf90c0 into nunit:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect summary comments on Warn.If overloads

3 participants