Backport fix for "IDisposable & InstancePerTestCase" (PR 3843) #3904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds thread-safe increments for BaseLifeCycle. Note that this only allows running multithreaded tests within a single LifeCycleAttributeTests test case. LifeCycleAttributeTests remains NonParallelizable (at least within a process) due to the use of static fields. Added an annotation to explicitly show so.
…BaseLifeCycle This surfaced that the tests actually were not running at all. After modifying the tests to instantiate the _nested_ fixture, it seems the attribute does not correctly inherit. To further verify this, added a quick local test case -- this can be removed later.
One of these is a failing test (nested class), as the corresponding 'regular' test is failing as well.
jnm2
approved these changes
Aug 2, 2021
rprouse
approved these changes
Aug 3, 2021
rprouse
deleted the
stevenaw/patch-v313-onetimesetup-instancepertestcase
branch
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #3844 to the v3.13-dev branch.
Fixes #3843