Marked 'NUnitEqualityComparer.AreEqual(object, object, Tolerance, bool)' as obsolete

[x789]

This is PR 1/2 that solves issue #3410.

Changes:

• Marked the method NUnitEqualityComparer.AreEqual(object, object, Tolerance, bool) as obsolete.
• Changed the only (internal) caller of that method AreEqual(object, object, Tolerance), so there are no internal references to the deprecated method.

[x789]

The CI builds failed on Linux/macOS due to a problem with the build script. Lacking the ability to reproduce it on my system, I would be happy if someone from the NUnit team can have a look at it?
Failed pipeline-run is 20211011.2
Output of Linux build:

Starting: Build, test, and publish results
==============================================================================
Task         : Bash
Description  : Run a Bash script on macOS, Linux, or Windows
Version      : 3.189.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/usr/bin/bash --noprofile --norc /home/vsts/work/_temp/49fde819-229f-461a-9145-0518e220c05b.sh
You can invoke the tool using the following command: dotnet-cake
Tool 'cake.tool' (version '1.3.0') was successfully installed.
/home/vsts/work/1/s/build.cake(325,34): error CS0034: Operator '+' is ambiguous on operands of type 'ConvertableDirectoryPath' and 'string'
/home/vsts/work/1/s/build.cake(329,30): error CS0034: Operator '+' is ambiguous on operands of type 'ConvertableDirectoryPath' and 'string'
Error: Error(s) occurred when compiling build script:
/home/vsts/work/1/s/build.cake(325,34): error CS0034: Operator '+' is ambiguous on operands of type 'ConvertableDirectoryPath' and 'string'
/home/vsts/work/1/s/build.cake(329,30): error CS0034: Operator '+' is ambiguous on operands of type 'ConvertableDirectoryPath' and 'string'
##[error]Bash exited with code '1'.
Finishing: Build, test, and publish results

Output of macOS build:

Starting: Build, test, and publish results
==============================================================================
Task         : Bash
Description  : Run a Bash script on macOS, Linux, or Windows
Version      : 3.189.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /Users/runner/work/_temp/a989b848-0be0-4343-888b-605084aa05b2.sh

Welcome to .NET 5.0!
---------------------
SDK Version: 5.0.202

Telemetry
---------
The .NET tools collect usage data in order to help us improve your experience. It is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

Read more about .NET CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

----------------
Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only).
Learn about HTTPS: https://aka.ms/dotnet-https
----------------
Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
--------------------------------------------------------------------------------------
You can invoke the tool using the following command: dotnet-cake
Tool 'cake.tool' (version '1.3.0') was successfully installed.
/Users/runner/work/1/s/build.cake(325,34): error CS0034: Operator '+' is ambiguous on operands of type 'ConvertableDirectoryPath' and 'string'
/Users/runner/work/1/s/build.cake(329,30): error CS0034: Operator '+' is ambiguous on operands of type 'ConvertableDirectoryPath' and 'string'
Error: Error(s) occurred when compiling build script:
/Users/runner/work/1/s/build.cake(325,34): error CS0034: Operator '+' is ambiguous on operands of type 'ConvertableDirectoryPath' and 'string'
/Users/runner/work/1/s/build.cake(329,30): error CS0034: Operator '+' is ambiguous on operands of type 'ConvertableDirectoryPath' and 'string'
##[error]Bash exited with code '1'.
Finishing: Build, test, and publish results

[mikkelbu]

@x789 As far as I can tell we are starting to use version 1.3.0 of the cake.tool. Prior we used version 1.2.0 on this branch. Version 1.3.0 were uploaded to nuget for approx 7 days ago.

Successful build - https://nunit.visualstudio.com/NUnit/_build/results?buildId=4321&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=6c56d998-158d-5232-283c-5140104799fc

...
========================== Starting Command Output ===========================
/usr/bin/bash --noprofile --norc /home/vsts/work/_temp/9134b885-0e3c-436a-b040-f2ee3b2a8bfa.sh
You can invoke the tool using the following command: dotnet-cake
Tool 'cake.tool' (version '1.2.0') was successfully installed.
...

Failing build - https://nunit.visualstudio.com/NUnit/_build/results?buildId=4351&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=6c56d998-158d-5232-283c-5140104799fc

...
========================== Starting Command Output ===========================
/usr/bin/bash --noprofile --norc /home/vsts/work/_temp/694851fc-961f-42bd-ab2b-c42bcdac2383.sh
You can invoke the tool using the following command: dotnet-cake
Tool 'cake.tool' (version '1.3.0') was successfully installed.
/home/vsts/work/1/s/build.cake(325,34): error CS0034: Operator '+' is ambiguous on operands of type 'ConvertableDirectoryPath' and 'string'

The builds are working on master, but there we also have #3835. @rprouse can you see any problem in backporting #3835 to the v3.13-dev branch? (and perhaps change the version 1.1.0 to 1.3.0)

[rprouse]

The builds are working on master, but there we also have #3835. @rprouse can you see any problem in backporting #3835 to the v3.13-dev branch? (and perhaps change the version 1.1.0 to 1.3.0)

I don't see an issue with backporting. I had to make a bunch of changes, so we'll need to be careful to not break anything, but no issues...

[mikkelbu]

The builds are working on master, but there we also have #3835. @rprouse can you see any problem in backporting #3835 to the v3.13-dev branch? (and perhaps change the version 1.1.0 to 1.3.0)

I don't see an issue with backporting. I had to make a bunch of changes, so we'll need to be careful to not break anything, but no issues...

I can take a look at it this weekend, if nobody beats me to it.