Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that AfterTest always runs in AfterTestCommand #3963

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Ensure that AfterTest always runs in AfterTestCommand #3963

merged 1 commit into from
Oct 14, 2021

Conversation

manfred-brands
Copy link
Member

Fixes #3953 for master.

@manfred-brands manfred-brands mentioned this pull request Oct 14, 2021
Merged
rprouse
rprouse approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@rprouse rprouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rprouse rprouse merged commit 100a929 into nunit:master Oct 14, 2021
@manfred-brands manfred-brands deleted the master_dispose_after_failure branch October 15, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rprouse rprouse rprouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dispose is not called on test fixtures with LifeCycle.InstancePerTestCase without TearDown method
2 participants
@manfred-brands @rprouse