Skip to content

Drop netcore2.1 as a target (backport #3986) #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2022
Merged

Drop netcore2.1 as a target (backport #3986) #4045

merged 2 commits into from
Mar 2, 2022

Conversation

stevenaw
Copy link
Member

@stevenaw stevenaw commented Mar 1, 2022

Fixes #4043
Backports PR #3986 onto v3.13 (fixed in 4.0 in #3980)

@stevenaw stevenaw added this to the 3.13.3 milestone Mar 1, 2022
@stevenaw
Copy link
Member Author

stevenaw commented Mar 1, 2022

And the CI build is passing (phew).
@manfred-brands @rprouse you both were involved in the PR to main. Do you mind taking a look at this please?

@stevenaw stevenaw requested a review from rprouse March 1, 2022 17:58
manfred-brands
manfred-brands approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

rprouse
rprouse approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@rprouse rprouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rprouse rprouse merged commit 6a024af into v3.13-dev Mar 2, 2022
@rprouse rprouse deleted the backport-3986 branch March 2, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rprouse rprouse rprouse approved these changes

@manfred-brands manfred-brands manfred-brands approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.3
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenaw @rprouse @manfred-brands