Replace net45 support with net462 #4050
Conversation
| @@ -164,13 +164,13 @@ Task("CheckForError") | |||
| .Description("Checks for errors running the test suites") | |||
| .Does(() => CheckForError(ref ErrorDetail)); | |||
|
|
|||
| Task("Test45") | |||
| .Description("Tests the .NET 4.5 version of the framework") | |||
| Task("TestNetFramework") | |||
There was a problem hiding this comment.
I had to update this build target name so that it would continue to make sense. I opted for this to make it version-agnostic (and complimentary to the pre-existing "TestNetStandard20"). I'm not totally happy with it and am hoping for feedback or suggestions here
There was a problem hiding this comment.
I do like it as we want to test the .net framework version. This way you don't have to update if once we move the minimum target to 4.8
| @@ -317,6 +317,7 @@ public override string ToString() | |||
| new FrameworkData(RuntimeType.NetFramework, new Version(3,5), new Version(2,0,50727), "net-3.5", "Net 3.5"), | |||
| new FrameworkData(RuntimeType.NetFramework, new Version(4,0), new Version(4,0,30319), "net-4.0", "Net 4.0"), | |||
| new FrameworkData(RuntimeType.NetFramework, new Version(4,5), new Version(4,0,30319), "net-4.5", "Net 4.5"), | |||
| new FrameworkData(RuntimeType.NetFramework, new Version(4,6), new Version(4,0,30319), "net-4.6", "Net 4.6"), | |||
There was a problem hiding this comment.
The current code doesn't support reading "build" numbers from the provided Version so I left it like this for now but I'd appreciate some feedback on this area please.
|
@nunit/framework-team I've taken a first-run at making this update. CI is currently a bit of an issue, but I'd appreciate some early feedback on some of the issues noted above please. |
|
|
||
|  | ||
|
|
||
| Because NUnit solution targets multiple frameworks, JetBrains Rider knows this and offers the option to run the tests against a specific framework and/or all target frameworks. | ||
|
|
||
| Unfortunately, there is currently a known issue ([#3008](https://github.com/nunit/nunit/issues/3008)) preventing the tests from being run in Visual Studio and JetBrains Rider IDEs. Equally there is also a known issue ([#3867](https://github.com/nunit/nunit/issues/3867)) preventing the tests from being run from the command line using `dotnet test` |
There was a problem hiding this comment.
I've moved this into a "Known Issues and Workarounds" section below to give it a "problem /solution" structure to hopefully clarify it a bit for readers
|
Latest merge conflicts have been resolved. This should now be ready for review. |
|
Thanks @manfred-brands ! |
| @@ -56,17 +55,15 @@ The tests that should be run in the solution are grouped by project name: | |||
|
|
|||
| Other test projects contain tests designed to fail purposely for integration tests. | |||
|
|
|||
| Normally you should be able to run the unit tests directly from within your development IDE of choice (as you would when using NUnit in any other development project). For example, this is what it looks like in JetBrains Rider (2021.1.2) when right clicking on the `AssertEqualsTests` TextFixture: | |||
| You should then be able to run the unit tests directly from within your development IDE of choice against one or all target frameworks (as you would when using NUnit in any other development project). For example, this is what it looks like in JetBrains Rider (2021.1.2) when right clicking on the `AssertEqualsTests` TextFixture: | |||
There was a problem hiding this comment.
I initially, thought that it was odd to write "You should then be able to run the unit tests directly from within...." and then later have "Known Issues and Workarounds", but looking at the resulting page I think this is fine
|
Thanks @mikkelbu ! |
Fixes #4036
Fixes #3989
Updates the framework to target net462 where it had been targeting net45 prior. Updates some of the build documentation too.