Skip to content

Use pattern matching in the comparers #4066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

stevenaw
Copy link
Member

@stevenaw stevenaw commented Mar 16, 2022

Fixes #4065

A small clean-up PR on an old part of the codebase to opt into newer language features with the possibility of small perf boost

more pattern matching

make a const where it can be
Copy link
Member

@rprouse rprouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@stevenaw stevenaw merged commit 61b6705 into nunit:master Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pattern matching in the comparers
3 participants