Fix ParallelizableAttribute with TestFixtureSource - #4099
SimonCropp merged 2 commits into
Conversation
|
Hello, we are waiting for that fix to update to the latest version. Anyone ready for the review? |
|
Hey @SimonCropp anything I can do to get this merged? |
|
@jairbubbles LGTM. but i am not a maintainer on this project, so cant merge |
|
Oh sorry I found your name in the last PRs merged but I guess you were just the author then. |
|
(Thx @stevenaw for updating my branch) |
|
Hi @stevenaw, anything I can do to help this PR getting merged? |
|
Hi @jairbubbles thanks for asking. Nothing on your end, this just needs a review by the team. Sorry it's taken so long to be looked at. I'd hoped to review it but I got a little unexpectedly busy myself. I still hope to get to this soon. |
|
@stevenaw This looks very simple. Do you think we can just merge it? |
stevenaw
left a comment
There was a problem hiding this comment.
I'd be alright with that @OsirisTerje
This LGTM too, thanks @jairbubbles for your contribution!
|
I'm having a bit of a hard time merging. |
bac37e3 to
ade5b0e
Compare
|
I rebased and resolved the conflict manually. |
Tests declared like that:
were no longer run in parallel since that change: 247ede8
Similar to #3715 I explicitely apply
ParallelizableAttributeto children tests.Closes #3735
NB: I couldn't run tests in master branch so I tested in the 3.0 dev branch.